On 07/09/2024 13:06, Nick Chan wrote: > > diff --git a/include/linux/serial_s3c.h b/include/linux/serial_s3c.h > index 1672cf0810ef..849d502d348d 100644 > --- a/include/linux/serial_s3c.h > +++ b/include/linux/serial_s3c.h > @@ -246,24 +246,28 @@ > S5PV210_UFCON_TXTRIG4 | \ > S5PV210_UFCON_RXTRIG4) > > -#define APPLE_S5L_UCON_RXTO_ENA 9 > -#define APPLE_S5L_UCON_RXTHRESH_ENA 12 > -#define APPLE_S5L_UCON_TXTHRESH_ENA 13 > -#define APPLE_S5L_UCON_RXTO_ENA_MSK (1 << APPLE_S5L_UCON_RXTO_ENA) > -#define APPLE_S5L_UCON_RXTHRESH_ENA_MSK (1 << APPLE_S5L_UCON_RXTHRESH_ENA) > -#define APPLE_S5L_UCON_TXTHRESH_ENA_MSK (1 << APPLE_S5L_UCON_TXTHRESH_ENA) > +#define APPLE_S5L_UCON_RXTO_ENA 9 > +#define APPLE_S5L_UCON_RXTO_LEGACY_ENA 11 > +#define APPLE_S5L_UCON_RXTHRESH_ENA 12 > +#define APPLE_S5L_UCON_TXTHRESH_ENA 13 > +#define APPLE_S5L_UCON_RXTO_ENA_MSK (1 << APPLE_S5L_UCON_RXTO_ENA) > +#define APPLE_S5L_UCON_RXTO_LEGACY_ENA_MSK (1 << APPLE_S5L_UCON_RXTO_LEGACY_ENA) > +#define APPLE_S5L_UCON_RXTHRESH_ENA_MSK (1 << APPLE_S5L_UCON_RXTHRESH_ENA) > +#define APPLE_S5L_UCON_TXTHRESH_ENA_MSK (1 << APPLE_S5L_UCON_TXTHRESH_ENA) Use BIT() for new entries. You can also convert the earlier defines to BIT() in separate patches. > Best regards, Krzysztof
