Error handling in probe() can be a bit simpler with dev_err_probe().
Signed-off-by: Yu Jiaoliang <yujiaoliang@xxxxxxxx>
---
drivers/tty/serial/samsung_tty.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
index c4f2ac9518aa..3550177010ad 100644
--- a/drivers/tty/serial/samsung_tty.c
+++ b/drivers/tty/serial/samsung_tty.c
@@ -1225,10 +1225,8 @@ static int s3c64xx_serial_startup(struct uart_port *port)
ret = request_irq(port->irq, s3c64xx_serial_handle_irq, IRQF_SHARED,
s3c24xx_serial_portname(port), ourport);
- if (ret) {
- dev_err(port->dev, "cannot get irq %d\n", port->irq);
- return ret;
- }
+ if (ret)
+ return dev_err_probe(port->dev, port->irq, "cannot get irq\n");
/* For compatibility with s3c24xx Soc's */
ourport->rx_enabled = 1;
--
2.34.1
