On Fri, Aug 09, 2024 at 12:04:23PM -0700, Kevin Hilman wrote: > Thomas Richard <thomas.richard@xxxxxxxxxxx> writes: > > > If the console suspend is disabled, the genpd of the console shall not > > be powered-off during suspend. > > Set the flag GENPD_FLAG_ALWAYS_ON to the corresponding genpd during > > suspend, and restore the original value during the resume. > > > > Signed-off-by: Thomas Richard <thomas.richard@xxxxxxxxxxx> > > Hmm, this patch got merged upstream (commit 68e6939ea9ec) even after > disagreements about the approach. > > Even worse, it actually causes a crash during suspend on platforms that > don't use PM domains (like AM335x Beaglebone Black.) > > Details on why this crashes below. > > Thomas, could you please submit a revert for this (with a Fixes: tag) > and then follow up with the approach as discussed later in this thread? Did this revert happen yet? thanks, greg k-h