Hi Andy,
Am 12.08.24 um 16:35 schrieb Andy Shevchenko:
The SIMPLE_DEV_PM_OPS() is deprecated, replace it with the
DEFINE_SIMPLE_DEV_PM_OPS() for setting the driver's PM routines.
it's possible the implementation doesn't use the optimal macros here.
But this sentence is a little bit confusing to me, because the code
doesn't use SIMPLE_DEV_PM_OPS().
Best regards
Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
---
drivers/tty/serial/8250/8250_bcm2835aux.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_bcm2835aux.c b/drivers/tty/serial/8250/8250_bcm2835aux.c
index 36e2bb34d82b..829abef2564d 100644
--- a/drivers/tty/serial/8250/8250_bcm2835aux.c
+++ b/drivers/tty/serial/8250/8250_bcm2835aux.c
@@ -245,9 +245,7 @@ static int bcm2835aux_resume(struct device *dev)
return 0;
}
-static const struct dev_pm_ops bcm2835aux_dev_pm_ops = {
- SYSTEM_SLEEP_PM_OPS(bcm2835aux_suspend, bcm2835aux_resume)
-};
+static DEFINE_SIMPLE_DEV_PM_OPS(bcm2835aux_dev_pm_ops, bcm2835aux_suspend, bcm2835aux_resume);
static struct platform_driver bcm2835aux_serial_driver = {
.driver = {
