On 08. 08. 24, 18:00, Lech Perczak wrote:
Comments attached to bits 0 and 1 incorrectly referenced bits 2 and 3, which doesn't match the datasheet. Fix them Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Cc: Jiri Slaby <jirislaby@xxxxxxxxxx> Cc: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> Cc: Andy Shevchenko <andy@xxxxxxxxxx> Signed-off-by: Lech Perczak <lech.perczak@xxxxxxxxxxxxxxx> --- drivers/tty/serial/sc16is7xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index 8a2020f9930e..c9695a3fd193 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -280,10 +280,10 @@ * XON1, XON2, XOFF1 and * XOFF2 */ -#define SC16IS7XX_EFR_SWFLOW1_BIT (1 << 1) /* SWFLOW bit 2 */ -#define SC16IS7XX_EFR_SWFLOW0_BIT (1 << 0) /* SWFLOW bit 3 +#define SC16IS7XX_EFR_SWFLOW1_BIT (1 << 1) /* SWFLOW bit 1 */ +#define SC16IS7XX_EFR_SWFLOW0_BIT (1 << 0) /* SWFLOW bit 0
Are the comments of any benefit here at all? It's clear what the macros are, right?
I'd only switch the macros to BIT() to make them more obvious.
* - * SWFLOW bits 3 & 2 table: + * SWFLOW bits 1 & 0 table:
This one is good, though. thanks, -- js suse labs
