While looking through the samsung tty driver, I've spotted a few things that can be simplified by removing unused function arguments and by avoiding some duplicated variables and casting. There are no functional changes here. Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx> --- Changes in v3: - undo too eager removal of 'const' where unnecessary (Jiri) - Link to v2: https://lore.kernel.org/r/20240807-samsung-tty-cleanup-v2-0-1db5afc9d41b@xxxxxxxxxx Changes in v2: - fix -Wdiscarded-qualifiers warnings - collect tags - Link to v1: https://lore.kernel.org/r/20240806-samsung-tty-cleanup-v1-0-a68d3abf31fe@xxxxxxxxxx --- André Draszik (2): tty: serial: samsung_tty: drop unused argument to irq handlers tty: serial: samsung_tty: cast the interrupt's void *id just once drivers/tty/serial/samsung_tty.c | 29 ++++++++++++----------------- 1 file changed, 12 insertions(+), 17 deletions(-) --- base-commit: 1e391b34f6aa043c7afa40a2103163a0ef06d179 change-id: 20240806-samsung-tty-cleanup-ffae1515a284 Best regards, -- André Draszik <andre.draszik@xxxxxxxxxx>