On Wed, 2024-08-07 at 13:09 +0200, Greg Kroah-Hartman wrote: > On Tue, Aug 06, 2024 at 04:29:44PM +0100, André Draszik wrote: > > While looking through the samsung tty driver, I've spotted a few things that > > can be simplified by removing unused function arguments and by avoiding some > > duplicated variables and casting. > > > > There are no functional changes here. > > > > Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx> > > --- > > André Draszik (2): > > tty: serial: samsung_tty: drop unused argument to irq handlers > > tty: serial: samsung_tty: cast the interrupt's void *id just once > > This series blows up the build for me, are you sure you tested it? > > drivers/tty/serial/samsung_tty.c: In function ‘s3c64xx_serial_handle_irq’: > drivers/tty/serial/samsung_tty.c:948:45: error: passing argument 1 of ‘s3c24xx_serial_rx_irq’ discards ‘const’ qualifier from pointer > target type [-Werror=discarded-qualifiers] > 948 | ret = s3c24xx_serial_rx_irq(ourport); > | ^~~~~~~ > drivers/tty/serial/samsung_tty.c:856:68: note: expected ‘struct s3c24xx_uart_port *’ but argument is of type ‘const struct > s3c24xx_uart_port *’ > > And so on... Odd, I did test this, yes. Not sure why I don't get these, let me check. Cheers, Andre'
