> From: "Yixun Lan"<dlan@xxxxxxxxxx> > Date: Fri, Jul 5, 2024, 14:47 > Subject: Re: [PATCH v3 06/11] dt-bindings: serial: 8250: Add SpacemiT K1 uart compatible > To: "Jisheng Zhang"<jszhang@xxxxxxxxxx> > Cc: "Rob Herring"<robh@xxxxxxxxxx>, "Krzysztof Kozlowski"<krzk+dt@xxxxxxxxxx>, "Conor Dooley"<conor+dt@xxxxxxxxxx>, "Conor Dooley"<conor@xxxxxxxxxx>, "Paul Walmsley"<paul.walmsley@xxxxxxxxxx>, "Palmer Dabbelt"<palmer@xxxxxxxxxxx>, "Albert Ou"<aou@xxxxxxxxxxxxxxxxx>, "Daniel Lezcano"<daniel.lezcano@xxxxxxxxxx>, "Thomas Gleixner"<tglx@xxxxxxxxxxxxx>, "Samuel Holland"<samuel.holland@xxxxxxxxxx>, "Anup Patel"<anup@xxxxxxxxxxxxxx>, "Greg Kroah-Hartman"<gregkh@xxxxxxxxxxxxxxxxxxx>, "Jiri Slaby"<jirislaby@xxxxxxxxxx>, "Lubomir Rintel"<lkundrak@xxxxx>, <devicetree@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, "Yangyu Chen"<cyy@xxxxxxxxxxxx>, "Conor Dooley"<conor.dooley@xxxxxxxxxxxxx>, "Inochi Amaoto"<inochiama@xxxxxxxxxxx>, <linux-serial@xxxxxxxxxxxxxxx>, <linux-riscv@xxxxxxxxxxxxxxxxxxx>, "Meng Zhang"<zhangmeng.kevin@xxxxxxxxxxxx> > On 22:03 Thu 04 Jul , Jisheng Zhang wrote: > > On Wed, Jul 03, 2024 at 02:55:09PM +0000, Yixun Lan wrote: > > > Found SpacemiT's K1 uart controller is compatible with > > > Intel's Xscale uart, but it's still worth to introduce a new compatible. > > > > Per vendor's kernel source code, all the uarts support 64Bytes FIFO. > > So if it's compatible with Xscale, it's a xscale uart 64 Bytes FIFO. > yes, I agree > > further question would how to implement specific support for spacemit's k1 SoC > one possible option to add a PORT_SPACEMIT compatible data to 8250_port.c - uart_config[] > > > > >From this PoV, the uart isn't a Xscale but a mrvl pxa. > see my previous comment, probably need further clarification/investigation.. > > > > > But I have one question: is the uart really a mrvl/intel pxa uart? or is just > No, I'm unable to answer this, I'm not an employee of SpacemiT > All informations are based on public available source + docs.. > > > reg programming compatible with pxa? > > > To my knowledge, it's compatible with pxa, but it would be great that vendor can clarify this Yes, the programming model is compatible with pxa. > > > > > > > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > > Signed-off-by: Yixun Lan <dlan@xxxxxxxxxx> > > > --- > > > Documentation/devicetree/bindings/serial/8250.yaml | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/serial/8250.yaml b/Documentation/devicetree/bindings/serial/8250.yaml > > > index 692aa05500fd5..0bde2379e8647 100644 > > > --- a/Documentation/devicetree/bindings/serial/8250.yaml > > > +++ b/Documentation/devicetree/bindings/serial/8250.yaml > > > @@ -111,7 +111,9 @@ properties: > > > - mediatek,mt7623-btif > > > - const: mediatek,mtk-btif > > > - items: > > > - - const: mrvl,mmp-uart > > > + - enum: > > > + - mrvl,mmp-uart > > > + - spacemit,k1-uart > > > - const: intel,xscale-uart > > > - items: > > > - enum: > > > > > > -- > > > 2.45.2 > > > > > > > > > _______________________________________________ > > > linux-riscv mailing list > > > linux-riscv@xxxxxxxxxxxxxxxxxxx > > > http://lists.infradead.org/mailman/listinfo/linux-riscv > > -- > Yixun Lan (dlan) > Gentoo Linux Developer > GPG Key ID AABEFD55 This message and any attachment are confidential and may be privileged or otherwise protected from disclosure. If you are not an intended recipient of this message, please delete it and any attachment from your system and notify the sender immediately by reply e-mail. Unintended recipients should not use, copy, disclose or take any action based on this message or any information contained in this message. Emails cannot be guaranteed to be secure or error free as they can be intercepted, amended, lost or destroyed, and you should take full responsibility for security checking. 本邮件及其任何附件具有保密性质，并可能受其他保护或不允许被披露给第三方。如阁下误收到本邮件，敬请立即以回复电子邮件的方式通知发件人，并将本邮件及其任何附件从阁下系统中予以删除。如阁下并非本邮件写明之收件人，敬请切勿使用、复制、披露本邮件或其任何内容，亦请切勿依本邮件或其任何内容而采取任何行动。电子邮件无法保证是一种安全和不会出现任何差错的通信方式，可能会被拦截、修改、丢失或损坏，收件人需自行负责做好安全检查。
