Hi On 13:24 Mon 01 Jul , Conor Dooley wrote: > On Thu, Jun 27, 2024 at 03:31:17PM +0000, Yixun Lan wrote: > > From: Yangyu Chen <cyy@xxxxxxxxxxxx> > > > > Add DT binding documentation for the SpacemiT K1 Soc[1] and the Banana > > Pi BPi-F3 board[2] which used it. > > > > [1] https://www.spacemit.com/en/spacemit-key-stone-2/ > > [2] https://docs.banana-pi.org/en/BPI-F3/BananaPi_BPI-F3 > > > > Please make these link tags when you resend, like > > Link: https://foo [1] > > and don't leave blank lines between them and the signoff. > sure, will fix in v3 > > Signed-off-by: Yangyu Chen <cyy@xxxxxxxxxxxx> > > Signed-off-by: Yixun Lan <dlan@xxxxxxxxxx> > > --- > > .../devicetree/bindings/riscv/spacemit.yaml | 24 ++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/riscv/spacemit.yaml b/Documentation/devicetree/bindings/riscv/spacemit.yaml > > new file mode 100644 > > index 0000000000000..3b151fd02473e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/riscv/spacemit.yaml > > @@ -0,0 +1,24 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/riscv/spacemit.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: SpacemiT SoC-based boards > > + > > +description: > > + SpacemiT SoC-based boards > > Please work out who is gonna maintain these SoCs and add that here to > resolve the bot's report. > sure, talked to Yangyu, will also add him as maintainer this should fix bot's complaint.. btw, thanks for all your other comments in the whole thread, will fix them all > Thanls, > Conor. > > > + > > +properties: > > + $nodename: > > + const: '/' > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - bananapi,bpi-f3 > > + - const: spacemit,k1 > > + > > +additionalProperties: true > > + > > +... > > > > -- > > 2.45.2 > > -- Yixun Lan (dlan) Gentoo Linux Developer GPG Key ID AABEFD55