On 13/06/2024 12:22, Hui Wang wrote: > > On 6/13/24 17:08, Krzysztof Kozlowski wrote: >> On 13/06/2024 10:25, Hui Wang wrote: >>> In some designs, the chip reset pin is connected to a GPIO, and this >>> GPIO needs to be set correctly before probing the driver, so add a >>> reset-gpios in the device tree. >>> >>> Signed-off-by: Hui Wang <hui.wang@xxxxxxxxxxxxx> >> <form letter> >> This is a friendly reminder during the review process. >> >> It looks like you received a tag and forgot to add it. >> >> If you do not know the process, here is a short explanation: >> Please add Acked-by/Reviewed-by/Tested-by tags when posting new >> versions, under or above your Signed-off-by tag. Tag is "received", when >> provided in a message replied to you on the mailing list. Tools like b4 >> can help here. However, there's no need to repost patches *only* to add >> the tags. The upstream maintainer will do that for tags received on the >> version they apply. >> >> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 >> >> If a tag was not added on purpose, please state why and what changed. >> </form letter> > > Got it. Will add that tag if I need to change sth in the v4 and need to > send the v5. :-) I thought the Ack is for Hugo's explanation rather than > for my 1st patch, I mis-understood it. And I plan to study b4 in the > near future. > Please start using b4. There would be no such ambiguity from your side, because maintainers know what they do and tool handles it correctly. Best regards, Krzysztof
