On Sat, Jun 08, 2024 at 12:47:40PM +0300, Andy Shevchenko wrote: > Fri, Jun 07, 2024 at 07:43:30PM +0800, Crescent Hsieh kirjoitti: > > There are 6 patches within this patch series to make some adjustments > > and enhancements for MOXA PCI serial boards, a briefly description is > > written below: > > > > - The first patch is an independent bug fix patch. > > - The second and third patches migrate some MOXA PCI devices from > > `mxser.c` to `8250_pci.c`. > > - The fourth and fifth patches address improvements and adjustments in > > handling the serial interface. > > - The sixth patch adds a UART configuration that aligns with the > > hardware capabilities of MOXA PCI serial boards. > > Everything is fine except one issue. Can we avoid polluting 8250_pci? > What I would expect as a patch 2 is a separation of 8250_moxa from > 8250_pci (see examples how it was done in the past: 8250_exar, 8250_lpss, > 8250_mid, ...) and then updating code there. Can it be achievable? Agree, I have been putting too much stuff into `8250_pci.c`. I will send the bug fix patch first, then create a new patch series to split the code into `8250_moxa.c`. --- Sincerely, Crescent Hsieh
