Re: [bug report] tty: serial: Add Nuvoton ma35d1 serial driver support

[Jacky Huang <ychuang570808@xxxxxxxxx>]

Dear Dan,


On 2024/6/8 下午 10:24, Dan Carpenter wrote:
> Hello Jacky Huang,
>
> Commit 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver
> support") from Jun 19, 2023 (linux-next), leads to the following
> Smatch static checker warning:
>
>          drivers/tty/serial/ma35d1_serial.c:713 ma35d1serial_probe()
>          error: we previously assumed 'pdev->dev.of_node' could be null (see line 691)
>
> drivers/tty/serial/ma35d1_serial.c
>      685 static int ma35d1serial_probe(struct platform_device *pdev)
>      686 {
>      687         struct resource *res_mem;
>      688         struct uart_ma35d1_port *up;
>      689         int ret = 0;
>      690
>      691         if (pdev->dev.of_node) {
>                      ^^^^^^^^^^^^^^^^^
> Check for NULL
>
>      692                 ret = of_alias_get_id(pdev->dev.of_node, "serial");

Thank you for point out this bug. I will fix it.


Best Regards,
Jacky Huang