On Tue, 4 Jun 2024 21:27:25 +0800
Hui Wang <hui.wang@xxxxxxxxxxxxx> wrote:
> In some designs, the chip reset pin is connected to a gpio, this
"and this ..."
> gpio needs to be set correctly before probing the driver, so adding
"so add ..."
> a reset-gpios in the device tree.
>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Signed-off-by: Hui Wang <hui.wang@xxxxxxxxxxxxx>
> ---
> In the v2:
> - include the gpio.h
> - run the 'make dt_binding_check' and 'make dtbs_check'
>
> Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
> index 5dec15b7e7c3..88871480018e 100644
> --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
> +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
> @@ -28,6 +28,9 @@ properties:
> clocks:
> maxItems: 1
>
> + reset-gpios:
> + maxItems: 1
> +
> clock-frequency:
> description:
> When there is no clock provider visible to the platform, this
> @@ -91,6 +94,7 @@ unevaluatedProperties: false
> examples:
> - |
> #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/gpio/gpio.h>
> i2c {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -120,6 +124,7 @@ examples:
> compatible = "nxp,sc16is752";
> reg = <0x54>;
> clocks = <&clk20m>;
> + reset-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
> interrupt-parent = <&gpio3>;
> interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
> nxp,modem-control-line-ports = <0 1>; /* Ports 0 and 1 as modem control lines */
> --
> 2.34.1
>
>
>
--
Hugo Villeneuve
