> On 18.05.24 00:17, Conor Dooley wrote: > On Fri, May 17, 2024 at 02:17:11PM +0800, Hal Feng wrote: > > The UART of StarFive JH7110 has two reset signals. > > Both of them are necessary for JH7110 to initialize UART. > > > > Signed-off-by: Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> > > --- > > .../bindings/serial/snps-dw-apb-uart.yaml | 14 +++++++++++++- > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > > index 1001d2a6ace8..a6396c5cbfb1 100644 > > --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > > +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > > @@ -13,6 +13,16 @@ allOf: > > - $ref: serial.yaml# > > - $ref: rs485.yaml# > > > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: starfive,jh7110-uart > > + then: > > + properties: > > + resets: > > + minItems: 2 > > else: > properties: > resets: > maxItems: 1 Will fix it later. Thanks for your review. Best regards, Hal