On Wed, May 08, 2024 at 07:28:35PM +0100, Greg Kroah-Hartman wrote: > On Wed, May 08, 2024 at 08:52:24AM +0700, Bagas Sanjaya wrote: > > What do you think about above feature request? > > We will be glad to review any submitted patches for any features. > patches in bugzilla are not viable for obvious reasons. Bagas, Note that the feature request is related to PPS, so per the MAINTAINERS file entry: PPS SUPPORT M: Rodolfo Giometti <giometti@xxxxxxxxxxxx> L: linuxpps@xxxxxxxxxxxxxxx (subscribers-only) S: Maintained W: http://wiki.enneenne.com/index.php/LinuxPPS_support F: Documentation/ABI/testing/sysfs-pps F: Documentation/devicetree/bindings/pps/pps-gpio.yaml F: Documentation/driver-api/pps.rst F: drivers/pps/ F: include/linux/pps*.h F: include/uapi/linux/pps.h I'd suggest that you reach out to Rondolfo as the maintainer, or to the linuxpps mailing list. First of all, looking at the patch referenced in the bugzilla (which is actually found in github), it appears that the person who made the request via Bugzilla is different from the the person who authored the patch (apparently, github.com/not1337). Secondly, the patch is really quite hacky. First, the termonology used of "4wire" is non-standard (e.g., uised nowhere but at github.com/not1337/pss-stuff), and misleading. A cable which only has RxD, TxD, RTS, and CTS is not going to work well without GND, so "4 wire" is quite the misnomer". This termonology is also not used by FreeBSD, BTW. Secondly, unconditionally mapping CTS to DCD when setting a magic UART-level attribute is a bit hacky, since it will do this magic ad-hoc mapping all of the time, not only if the PPS line discpline is selected. Now, I haven't been the tty maintainer in quite a while, but in my opinion, a much cleaner way would be to plumb a new tty ldisc function, cts_change, which is analogous to the dcd_change function (which was introduced specifically for pps_ldisc). Then for bonus points, consider using the pps capture mode mde that FreeeBSD's UART driver, including the invert option and narrow pulse mode, and eschew using the non-standard "4wire" naming terminology. Finally, note that the way kernel development works is that it's not enough for a user to ask for a feature. Someone has to create a high quality, clean, maintainable patch. Note all random hacks found in random Bugzilla or Github git trees are suitable for inclusion in the upstream kernel. And if you don't know how to evaluate the patch for quality, it might not be best thing to just ask the bugzilla requester to follow the Submitting Patches procedure, given that (a) they might not be a kernel developer, and (b) it might just frustrate the bugzilla requester and maintainer if the patch isn't sufficient high quality, especially if you've managed to set expectations that all the bugzilla requestor needs to do is to submit the patch and it will be accepted. Cheers, - Ted
