On 06/05/2024 18:16, Conor Dooley wrote: >>>> +maintainers: >>>> + - Christoph Fritz <christoph.fritz@xxxxxxxxx> >>>> + >>>> +properties: >>>> + compatible: >>>> + const: hexdev,lin-serdev >>> >>> Maybe I've just missed something on earlier versions that I didn't >>> read, but the name of the device on the website you link is "hexLIN", >>> so why is "lin-serdev" used here instead? >> >> The USB one is called hexLIN and has it's own HID driver. >> >> This serial LIN adapter doesn't really have a product name. Currently >> on our website it's generically called 'UART LIN Adapter'. >> >> This LIN adapter is basically just a LIN transceiver and very generic, >> so that one could solder it to any single-board computer with an uart. >> >> I think 'lin-serdev' for LIN and serial device fits great, also serdev >> is the name of the used kernel infrastructure (besides the LIN glue >> driver). >> >> If you still don't like it, I'm open to other names. What about >> "hexlin-uart" or "linser"? > > I dunno, I don't really care about it being called "hexlin,lin-serdev", > all that much, I just found it confusing that the link in the description > sent me to the ""Hello World" in LIN" section of your site. If it had > dropped me off at the "UART LIN adapter" section things woud've been less > confusing. > > That said, calling the compatible after a linux-ism is a bit odd to me > when the device seems to be called a "UART LIN adapter" on the page, not > a "serdev". > If there is no real, fixed model name, I would also propose to use whatever is on the website currently and avoid Linuxism. Best regards, Krzysztof
