On Tue, Apr 23, 2024 at 04:49:30PM +0300, Ilpo Järvinen wrote: > 8250_pnp sets drvdata to line + 1 if the probe is successful. The users > of drvdata are in remove, suspend and resume callbacks, none of which > will be called if probe failed. The line acquired from drvdata can > never be zero in those functions and the checks for that can be > removed. > > Eliminate also +/-1 step because all users of line subtract 1 from the > value. > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > --- > drivers/tty/serial/8250/8250_pnp.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) Doesn't apply to my tty-next branch, can you rebase and resend? thanks, greg k-h
