On Fri, May 03, 2024 at 02:31:22PM +0530, Shresth Prasad wrote: > On Fri, May 3, 2024 at 11:04 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > On Thu, May 02, 2024 at 10:21:16PM +0530, Shresth Prasad wrote: > > > On Thu, May 2, 2024 at 9:35 PM Ilpo Järvinen > > > <ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote: > > > > > > > > On Wed, 1 May 2024, Shresth Prasad wrote: > > > > > > > > > Add `__free` function attribute to `ap` and `match` pointer > > > > > initialisations which ensure that the pointers are freed as soon as they > > > > > go out of scope, thus removing the need to manually free them using > > > > > `of_node_put`. > > > > > > > > > > This also removes the need for the `goto` statement and the `rc` > > > > > variable. > > > > > > > > > > Tested using a qemu x86_64 virtual machine. > > > > > > > > Eh, how can you test this with an x86_64 VM ??? > > > > > > > > config SERIAL_SUNSU > > > > tristate "Sun SU serial support" > > > > depends on SPARC && PCI > > > > > > > > > > By that, I mean that I compiled the kernel and ran the produced bzImage > > > on a x86_64 qemu machine. > > > > But you didn't include the driver you were testing :( > > > > > I unfortunately don't have the hardware to test it on, but I don't > > > think the change is complex enough to require testing on real hardware > > > (unless I'm assuming incorrectly). > > > > That's why I asked if you had tested this or not... > > > > Really sorry about that, I thought compiling and booting would qualify > as testing. What should I be doing then? Compiling and booting the code you change would be a good start :) thanks, greg k-h
