On Thu, 2 May 2024 17:43:54 +0300 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > After a rework for CONNTECH was done, the driver may need a bit of > love in order to become less verbose (in terms of indentation and > code duplication) and hence easier to read. > > This clean up series fixes a couple of (not so critical) issues and > cleans up the recently added code. No functional change indented by > the cleaning up part. > Just an FYI I submitted a patch series that fixed several of these issues but I think it fell through the cracks (I know everyone is very busy!). Link: https://lore.kernel.org/linux-serial/cover.1713533298.git.pnewman@xxxxxxxxxxxxxxx/ I believe my previous patch series is no longer required. This one fixes everything. Thanks, Parker > Andy Shevchenko (13): > serial: 8250_exar: Don't return positive values as error codes > serial: 8250_exar: Describe all parameters in kernel doc > serial: 8250_exar: Kill CTI_PCI_DEVICE() > serial: 8250_exar: Use PCI_SUBVENDOR_ID_IBM for subvendor ID > serial: 8250_exar: Trivia typo fixes > serial: 8250_exar: Extract cti_board_init_osc_freq() helper > serial: 8250_exar: Kill unneeded ->board_init() > serial: 8250_exar: Decrease indentation level > serial: 8250_exar: Return directly from switch-cases > serial: 8250_exar: Switch to use dev_err_probe() > serial: 8250_exar: Use BIT() in exar_ee_read() > serial: 8250_exar: Make type of bit the same in exar_ee_*_bit() > serial: 8250_exar: Keep the includes sorted > > drivers/tty/serial/8250/8250_exar.c | 454 ++++++++++++---------------- > 1 file changed, 200 insertions(+), 254 deletions(-) >
