On Fri, Apr 26, 2024 at 5:36 PM Andy Shevchenko <andy@xxxxxxxxxx> wrote: > > On Thu, Apr 25, 2024 at 09:32:33PM +0300, Konstantin Pugin wrote: > > From: Konstantin Pugin <ria.freelander@xxxxxxxxx> > > > > When specifying flag SER_RS485_RTS_ON_SEND in RS485 configuration, > > we get the following warning after commit 4afeced55baa ("serial: core: > > fix sanitizing check for RTS settings"): > > > > invalid RTS setting, using RTS_AFTER_SEND instead > > > > This results in SER_RS485_RTS_AFTER_SEND being set and the > > driver always write to the register field SC16IS7XX_EFCR_RTS_INVERT_BIT, > > which breaks some hardware using these chips. > > > > The hardware supports both RTS_ON_SEND and RTS_AFTER_SEND modes, so fix > > this by announcing support for RTS_ON_SEND. > > Greg KH, who is maintainer of TTY/serial subsystem, usually asks to separate > fixes from new features. So, sending this patch separately may not only help > him, but let's move forward with your stuff. > Do I need to increase the version number in split send? And if I need to do so, then how I should do it? Only on new driver? Or only on fix? Should I CC linux-stable in fix patch? > -- > With Best Regards, > Andy Shevchenko > >