On Fri, Apr 26, 2024 at 02:39:59PM +0100, lumingyindetect@xxxxxxx wrote: > From: LuMingYin <lumingyindetect@xxxxxxx> > > The return statements at line 347 and line 351 in the lpss8250_probe() > function result in a memory leak of the variable pdev. Add a label named > free_irq_vectors in the lpss8250_probe() function to release the memory area > pointed to by pdev. Modify the two return statements mentioned above to jump > to the label "free_irq_vectors" instead. > Fixes: e88c4cfcb7b888ac374916806f86c17d8ecaeb67 ("serial: 8250_lpss: fix memory in lpss8250_probe()") Same as for the previous version, NAK. This patch does NOT fix anything. Please, read the code and try to understand how it works. -- With Best Regards, Andy Shevchenko