On Fri, Apr 19, 2024 at 5:08 PM Conor Dooley <conor@xxxxxxxxxx> wrote: > > On Fri, Apr 19, 2024 at 03:45:02PM +0300, Konstantin Pugin wrote: > > From: Konstantin Pugin <ria.freelander@xxxxxxxxx> > > > > Add EXAR XR20M1172 UART compatible line into devicetree documentation. > > What you're doing is obvious from the diff, why this exar device is > related to the nxp devices is what should be mentioned here. > > Thanks, > Conor. It is already mentioned in cover letter and in previous patches in the series. Do I need to repeat it in DTS patch? If so, I will do it. Citation from my cover letter: EXAR XR20M1172 UART is mostly SC16IS762-compatible, but it has additional register which can change UART multiplier to 4x and 8x, similar to UPF_MAGIC_MULTIPLIER does. So, I used this flag to guard access to its specific DLD register. It seems than other EXAR SPI UART modules also have this register, but I tested only XR20M1172. Yes, in datasheet this register is called "DLD - Divisor Fractional" or "DLD - Divisor Fractional Register", calling depends on datasheet version. Also, comparision from NXP itself: http://www.bdtic.com/download/nxp/75017168.pdf (pp12-13 is about XR20M1172). > > > > Reviewed-by: Vladimir Zapolskiy <vz@xxxxxxxxx> > > Signed-off-by: Konstantin Pugin <ria.freelander@xxxxxxxxx> > > --- > > Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml > > index 5dec15b7e7c3..c4bedf23368b 100644 > > --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml > > +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml > > @@ -12,6 +12,7 @@ maintainers: > > properties: > > compatible: > > enum: > > + - exar,xr20m1172 > > - nxp,sc16is740 > > - nxp,sc16is741 > > - nxp,sc16is750 > > -- > > 2.34.1 > >
