On Tue, Apr 16, 2024 at 07:20:18PM +0000, Michael Pratt wrote: > Hi Andy, > > On Tuesday, April 16th, 2024 at 14:58, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > ... > > > > > + if (port->fifosize > 1) > > > + port->timeout = uart_fifo_timeout(port); > > > > > > else > > port->timeout = port->frame_time; > > > > > Consistent with what I said in the other reply, the only reason that > I have an if statement here, is to avoid doing extra math for devices > without a fifo, as a specifically calculated timeout value would be useless > in those cases. > As we are talking about a device with a scale of KB/s, I am attempted to suggest to call uart_fifo_timeout() unconditionally. > However, if you don't like the 10 ms default timeout, perhaps port->frame_time > could actually be a more reasonable default value? That is, provided that we have a process > for calculating the proper value already in place... > > > > > -- > > With Best Regards, > > Andy Shevchenko > > > > Thanks for taking a look :D > > -- > MCP >
