On Tue, Apr 16, 2024 at 08:55:31AM -0400, Parker Newman wrote: > From: Parker Newman <pnewman@xxxxxxxxxxxxxxx> > > - Add an optional "board_init()" function pointer to struct > exar8250_board which is called once during probe prior to setting up > the ports. > > - Fix several "missing identifier name" warnings from checkpatch in > struct exar8250_platform and struct exar8250_board: > > WARNING: function definition argument <arg> should also have an > identifier name > > - Fix warning from checkpatch: > WARNING: please, no space before tabs > + * 0^I^I2 ^IMode bit 0$ > > Changes in v3: > - Renamed board_setup to board_init. > - Changed pci_err to dev_err_probe > - Added note above about checkpatch fixes > > Signed-off-by: Parker Newman <pnewman@xxxxxxxxxxxxxxx> > --- > drivers/tty/serial/8250/8250_exar.c | 23 +++++++++++++++++------ > 1 file changed, 17 insertions(+), 6 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c > index 388dd60ad23a..cf7900bd2974 100644 > --- a/drivers/tty/serial/8250/8250_exar.c > +++ b/drivers/tty/serial/8250/8250_exar.c > @@ -133,7 +133,7 @@ > * > * MPIO Port Function > * ---- ---- -------- > - * 0 2 Mode bit 0 > + * 0 2 Mode bit 0 This change isn't related to the exar8250_board change, right? Just keep exar8250_board change as one patch, and the coding style warning fixups as one for the very end, after you add all of your new functionality. thanks, greg k-h
