Re: [PATCH v1 1/1] serial: core: Clearing the circular buffer before NULLifying it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jiri Slaby <jirislaby@xxxxxxxxxx>
Subject: Re: [PATCH v1 1/1] serial: core: Clearing the circular buffer before NULLifying it
From: Tony Lindgren <tony@xxxxxxxxxxx>
Date: Fri, 5 Apr 2024 08:42:23 +0300
Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, Yicong Yang <yangyicong@xxxxxxxxxxxxx>, kernel test robot <oliver.sang@xxxxxxxxx>
In-reply-to: <f0f200b0-34dc-430b-b55e-b133faf4db44@kernel.org>
References: <20240404150034.41648-1-andriy.shevchenko@linux.intel.com> <f0f200b0-34dc-430b-b55e-b133faf4db44@kernel.org>

* Jiri Slaby <jirislaby@xxxxxxxxxx> [240405 05:25]:
> But again, serial8250_start_tx() should not be called after shutdown().

Sounds like we should add some check in addition to UPF_DEAD to
serial_port_runtime_suspend() and serial_port_runtime_resume() to
bail out early on shutdown.

Regards,

Tony

References:
- [PATCH v1 1/1] serial: core: Clearing the circular buffer before NULLifying it
  - From: Andy Shevchenko
- Re: [PATCH v1 1/1] serial: core: Clearing the circular buffer before NULLifying it
  - From: Jiri Slaby

Prev by Date: Re: [PATCH v1 1/1] serial: core: Clearing the circular buffer before NULLifying it
Next by Date: Re: [linus:master] [serial] 43066e3222: BUG:kernel_NULL_pointer_dereference,address
Previous by thread: Re: [PATCH v1 1/1] serial: core: Clearing the circular buffer before NULLifying it
Next by thread: Re: [PATCH v1 1/1] serial: core: Clearing the circular buffer before NULLifying it
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux PPP] [Linux FS] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Linmodem] [Device Mapper] [Linux Kernel for ARM]