On Fri, Apr 5, 2024 at 1:15 AM Finn Thain <fthain@xxxxxxxxxxxxxx> wrote: > On Thu, 4 Apr 2024, Andy Shevchenko wrote: > > > > > > --- > > > > (here is a good location for Cc:) > > > > > > Documentation/process/submitting-patches.rst indicats that it should > > > be above the "---" separator together with Acked-by etc. Has this > > > convention changed recently? > > > > I see, I will prepare a patch to discuss this aspect. > > If you are going to veto patches on the basis of rules yet unwritten, I > think you risk turning the kernel development process into a lottery. It's already a lottery, if you haven't noticed, i.e. it highly relies on the style preferences of the maintainers and is yet undocumented (a few years ago it was a new section introduced for closing this gap). > How many other patches presently under review will need to be dropped just > in case they don't conform with possible future rules? What you are saying is pure speculation. I rely on at least two things (besides already explained): - the fact that Submitting Patches refers to the commit message reduction due to the unnecessariness of some lines - my experience and common sense (why duplicate the data?). -- With Best Regards, Andy Shevchenko