Hi Greg,
On 4/4/24 09:50, Greg Kroah-Hartman wrote:
On Thu, Apr 04, 2024 at 09:44:50AM +0200, Bastien Curutchet wrote:
The UART's input clock rate can change at runtime but this is not
handled by the driver.
Add a clock_notifier callback that updates the divisors when the input
clock is updated. The serial8250_update_uartclk() is used to do so.
PRE_RATE_CHANGE and ABORT_RATE_CHANGE notifications are ignored, only
the POST_RATE_CHANGE is used.
Why just this one notification? You say they are ignored but do not say
why.
I don't need to react to PRE_RATE_CHANGE in my use case. A few bytes may
be corrupted during the rate change but it is not a problem for my
application (and I assumed that it would also be ok in many other use
cases).
Reorder the #include to match alphabetic order.
That is not needed here, why do that now? And "alphabetic order" is not
an issue for tty drivers, no need to do that, but if you really want to,
a separate patch series is good for that.
Ok sorry, I thought it was needed, I'll remove this in next iteration.
Best regards,
Bastien
