On Wed, Apr 03, 2024 at 03:41:27PM +0800, Guanbing Huang wrote: > From: Guanbing Huang <albanhuang@xxxxxxxxxxx> > > The 16550a serial port based on the ACPI table requires obtaining the > reg-shift attribute. In the ACPI scenario, If the reg-shift property > is not configured like in DTS, the 16550a serial driver cannot read or > write controller registers properly during initialization. > > To address the issue of configuring the reg-shift property, the > __uart_read_properties() universal interface is called to implement it. > Adaptation of pnp devices is done in the __uart_read_properties() function. Thank you! I have a few comments, mostly cosmetic except a couple in the last patch. Most likely the v4 will be good enough for merging. -- With Best Regards, Andy Shevchenko