On Tue, Apr 2, 2024 at 8:45 PM Hugo Villeneuve <hugo@xxxxxxxxxxx> wrote: > > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > Hello, > this patch series splits the SPI/I2C parts for the sc16is7xx driver into > separate source files (and separate I2C/SPI drivers). > > These changes are based on suggestions made by Andy Shevchenko > following this discussion: > > Link: https://lore.kernel.org/all/CAHp75VebCZckUrNraYQj9k=Mrn2kbYs1Lx26f5-8rKJ3RXeh-w@xxxxxxxxxxxxxx/ > > The changes are split into multiple patches to facilitate the review process. > In the end, some of them could be merged into a single patch. > > I have tested the changes on a custom board with two SC16IS752 DUART over > a SPI interface using a Variscite IMX8MN NANO SOM. The four UARTs are > configured in RS-485 mode. > > I did not test the changes on a real SC16is7xx using the I2C interface. But > I slighly modified the driver to be able to simulate an I2C device using slightly > i2c-stub. I was then able to instantiate a virtual I2C device without > disturbing existing connection/communication between real SPI devices on > /dev/ttySC0 and /dev/ttySC2 (using a loopback cable). For patches 1,2,5 Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx> -- With Best Regards, Andy Shevchenko
