Hi Prabhakar, > -----Original Message----- > From: Prabhakar <prabhakar.csengg@xxxxxxxxx> > Sent: Friday, March 22, 2024 2:44 PM > Subject: [PATCH v4 2/5] dt-bindings: serial: renesas,scif: Validate 'interrupts' and 'interrupt- > names' > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > This commit adds support to validate the 'interrupts' and 'interrupt-names' > properties for every supported SoC. This ensures proper handling and configuration of interrupt- > related properties across supported platforms. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > --- > v3->v4 > - Reverted back to v2 version of the patch. > - Used suggestion from Krzysztof for interrupts > - Restored RB tag from Geert > > v2->v3 > - Listed interrupts and interrupt-names for every SoC in if check > --- > .../bindings/serial/renesas,scif.yaml | 73 ++++++++++++++----- > 1 file changed, 55 insertions(+), 18 deletions(-) > > diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > index af72c3420453..eb2aa5e75e02 100644 > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > @@ -86,11 +86,6 @@ properties: > oneOf: > - items: > - description: A combined interrupt > - - items: > - - description: Error interrupt > - - description: Receive buffer full interrupt > - - description: Transmit buffer empty interrupt > - - description: Break interrupt > - items: > - description: Error interrupt > - description: Receive buffer full interrupt @@ -98,21 +93,17 @@ properties: > - description: Break interrupt > - description: Data Ready interrupt > - description: Transmit End interrupt > + minItems: 4 I think here minItems is 1 as it is either 1 or 4 or 6 Cheers, Biju > > interrupt-names: > - oneOf: > - - items: > - - const: eri > - - const: rxi > - - const: txi > - - const: bri > - - items: > - - const: eri > - - const: rxi > - - const: txi > - - const: bri > - - const: dri > - - const: tei > + minItems: 4 > + items: > + - const: eri > + - const: rxi > + - const: txi > + - const: bri > + - const: dri > + - const: tei > > clocks: > minItems: 1 > @@ -173,6 +164,52 @@ allOf: > required: > - resets > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - renesas,rcar-gen1-scif > + - renesas,rcar-gen2-scif > + - renesas,rcar-gen3-scif > + - renesas,rcar-gen4-scif > + then: > + properties: > + interrupts: > + maxItems: 1 > + > + interrupt-names: false > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - renesas,scif-r7s72100 > + then: > + properties: > + interrupts: > + minItems: 4 > + maxItems: 4 > + > + interrupt-names: > + maxItems: 4 > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - renesas,scif-r7s9210 > + - renesas,scif-r9a07g044 > + then: > + properties: > + interrupts: > + minItems: 6 > + > + interrupt-names: > + minItems: 6 > + > unevaluatedProperties: false > > examples: > -- > 2.34.1 >
