On Wed, Feb 28, 2024 at 11:15:23PM +0530, VAMSHI GAJJELA wrote: > On Mon, Feb 26, 2024 at 10:07 PM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Mon, Feb 26, 2024 at 09:30:53PM +0530, VAMSHI GAJJELA wrote: > > > On Thu, Feb 22, 2024 at 4:50 PM Uwe Kleine-König > > > <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: ... > > > I see any error should be caught at the following line, provided no > > > clock-frequency > > > ``` > > > /* If no clock rate is defined, fail. */ > > > if (!p->uartclk) > > > return dev_err_probe(dev, -EINVAL, "clock rate not defined\n"); > > > ``` > > > > Not sure what you meant by this. Even if we ask for an optional clock, > > the error condition still might happen with many other reasons besides > > the absence of the clock. > I was looking for a reason that the author has encountered. Error condition > on an optional clock might also fail `p->uartclk = clk_get_rate` and result > "clock rate not defined\n" error. Are you sure that CCF allows this to happen on real clocks? I mean, the rate of (existing) clock can be 0 iff the clock provider is powered off or unclocked itself (by parent clock). But I'm not sure this is the case CCF handles. -- With Best Regards, Andy Shevchenko
