Hello Ilpo, On Thu, Feb 22, 2024 at 01:50:40PM +0200, Ilpo Järvinen wrote: > On Thu, 22 Feb 2024, Uwe Kleine-König wrote: > > > Instead of silently giving up, at least tell what the problem is. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > --- > > drivers/tty/serial/8250/8250_dw.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c > > index 2d1f350a4bea..94aa3dddb71e 100644 > > --- a/drivers/tty/serial/8250/8250_dw.c > > +++ b/drivers/tty/serial/8250/8250_dw.c > > @@ -597,7 +597,8 @@ static int dw8250_probe(struct platform_device *pdev) > > if (data->clk == NULL) > > data->clk = devm_clk_get_optional_enabled(dev, NULL); > > if (IS_ERR(data->clk)) > > - return PTR_ERR(data->clk); > > + return dev_err_probe(dev, PTR_ERR(data->clk), > > + "failed to get baudclk\n"); > > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> Thanks. Is the expectation now with your tag that Greg (added to Cc:) picks up this patch? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
