On 2024-02-19, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: >> --- a/kernel/printk/nbcon.c >> +++ b/kernel/printk/nbcon.c >> @@ -6,6 +6,7 @@ >> #include <linux/console.h> >> #include <linux/delay.h> >> #include <linux/slab.h> >> +#include <linux/serial_core.h> > > The headers in this file is a mess. But here you can at least keep the > piece ordered, can you? Just to clarify, you would like to see this ordering and inclusion? #include <linux/bug.h> #include <linux/console.h> #include <linux/delay.h> #include <linux/export.h> #include <linux/kernel.h> #include <linux/serial_core.h> #include <linux/slab.h> #include <linux/string.h> #include "internal.h" >> + ret = (console_srcu_read_flags(up->cons) & CON_NBCON); > > The outer parentheses are redundant. Ack. Thanks. John
