On Wed, 14 Feb 2024, Ilpo Järvinen wrote: Gah, I seem to have botched the shortlog while I killed linux/ prefixes from it. I'll send an update tomorrow. -- i. > There's no need to include linux/tty_buffer.h in linux/tty.h. > Move the include into tty_buffer.c that is actually using it. > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > --- > drivers/tty/tty_buffer.c | 1 + > include/linux/tty.h | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c > index f8883afbeeba..79f0ff94ce00 100644 > --- a/drivers/tty/tty_buffer.c > +++ b/drivers/tty/tty_buffer.c > @@ -7,6 +7,7 @@ > #include <linux/errno.h> > #include <linux/minmax.h> > #include <linux/tty.h> > +#include <linux/tty_buffer.h> > #include <linux/tty_driver.h> > #include <linux/tty_flip.h> > #include <linux/timer.h> > diff --git a/include/linux/tty.h b/include/linux/tty.h > index 8c76fd97d4ad..2b2e6f0a54d6 100644 > --- a/include/linux/tty.h > +++ b/include/linux/tty.h > @@ -6,7 +6,6 @@ > #include <linux/major.h> > #include <linux/termios.h> > #include <linux/workqueue.h> > -#include <linux/tty_buffer.h> > #include <linux/tty_driver.h> > #include <linux/tty_ldisc.h> > #include <linux/tty_port.h> >