On Wed, Feb 14, 2024 at 10:15:10AM +0100, Jiri Slaby wrote: > On 13. 02. 24, 20:38, Andy Shevchenko wrote: > > Update header inclusions to follow IWYU (Include What You Use) > > principle. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > Looks good, but hard to tell if it is correct :P. > > I like this qt-creator feature: "this header is not directly used, remove?". > Maybe we could extend it to the kernel somehow (as it uses clang to decide, > I suppose). As was shown recently, removing the inclusion hell can decrease > the build time significantly… Yes, that's what Ingo's gigantic patch series targeted, but seems no-one is interested enough to get it through. clang people also wanted to have a tool like checkpatch for the inclusions or even like coccinelle to just fix the code, but it's a project with no deadline or milestones AFAIK. > Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx> Thank you! -- With Best Regards, Andy Shevchenko