On Fri, Feb 2, 2024 at 1:49 AM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 02/02/2024 02:05, Sam Protsenko wrote: > > Commit 59f37b7370ef ("tty: serial: samsung: Remove USI initialization") > > removes parameters from EXYNOS_COMMON_SERIAL_DRV_DATA() macro, but > > leaves unnecessary empty braces. Remove those to fix the style. No > > functional change. > > > > Fixes: 59f37b7370ef ("tty: serial: samsung: Remove USI initialization") > > Signed-off-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx> > > --- > > drivers/tty/serial/samsung_tty.c | 8 ++++---- > > I am pretty sure you did the patch on some old tree, not mainline rc1. > Please work on maintainers tree (or linux-next). > Hi Krzysztof, I worked on linux-next, and rebased it on top of the latest linux-next yesterday, right before submitting. I distinctly remember solving a conflict while rebasing, due to the new commit 0b87a9fd670a ("tty: serial: samsung: set UPIO_MEM32 iotype for gs101") which just got into linux-next yesterday. Please let me know if you want me to rebase it on another tree and re-submit. Thanks! > Best regards, > Krzysztof >