From: Jiri Slaby [mailto:jirislaby@xxxxxxxxxx] Sent: Friday, January 19, 2024 7:36 AM > On 18. 01. 24, 16:46, Christoph Niedermaier wrote: >> Since the commit 93f3350c46fa ("RS485: fix inconsistencies in the >> meaning of some variables"), the definition for bit 3 has been removed. >> But with the switch to bit shift macros in commit 76ac8e29855b ("tty: >> serial: Cleanup the bit shift with macro"), this gap wasn't preserved. >> To avoid a break in user/kernel api of the system skip bit 3 again and >> add a placeholder comment. >> >> Signed-off-by: Christoph Niedermaier <cniedermaier@xxxxxxxxxxxxxxxxxx> >> Fixes: 76ac8e29855b ("tty: serial: Cleanup the bit shift with macro") >> Fixes: 6056f20f27e9 ("tty: serial: Add RS422 flag to struct serial_rs485") >> --- > > This triple dash is superfluous and will likely break git am. OK. >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> Cc: Crescent CY Hsieh <crescentcy.hsieh@xxxxxxxx> >> Cc: Jiri Slaby <jirislaby@xxxxxxxxxx> >> Cc: Lukas Wunner <lukas@xxxxxxxxx> >> Cc: Lino Sanfilippo <l.sanfilippo@xxxxxxxxxx> >> Cc: Hugo Villeneuve <hugo@xxxxxxxxxxx> >> To: linux-serial@xxxxxxxxxxxxxxx >> To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > > "To" is not supported here, IMO. OK. > When you fix that: > Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx> I will create a version 3. [...] Regards Christoph
