On 15/01/2024 20:44, Frank Li wrote: > On Fri, Jan 12, 2024 at 11:06:01AM -0500, Frank Li wrote: >> On Fri, Jan 12, 2024 at 04:50:25PM +0100, Krzysztof Kozlowski wrote: >>> On 12/01/2024 16:31, Frank Li wrote: >>>> I review previous comments. The previous RFC patches and I just want I3C >>>> expert review to check if there are comments about whole software >>>> architecture. Of course, thank you for your comments about "slave". >>>> >>>> Go back this binding doc problem. >>>> >>>> "No, it's the same device. >>>> >>>> Anyway, this was not tested. >>>> >>>> Please use scripts/get_maintainers.pl to get a list of necessary people >>>> and lists to CC. It might happen, that command when run on an older >>>> kernel, gives you outdated entries. Therefore please be sure you base >>>> your patches on recent Linux kernel. >>>> >>>> You missed at least devicetree list (maybe more), so this won't be >>>> tested by automated tooling. Performing review on untested code might be >>>> a waste of time, thus I will skip this patch entirely till you follow >>>> the process allowing the patch to be tested. >>>> >>>> Please kindly resend and include all necessary To/Cc entries. >>>> " >>>> >>>> It is the same devices, work at difference mode (master and target). >>>> what's do you want to change to? >>>> >>>> Copy to new file like pci/pci-ep? all context is the same, except for >>>> compatible string. >>>> >>> >>> Apologies, I mixed up a bit patches, so this was not obvious. I meant >>> this comment: >>> >>> https://lore.kernel.org/all/20231017201404.GA2570433-robh@xxxxxxxxxx/ >>> >>> There is no indication in your commit msg that these concerns were >>> addressed. >> >> Look like everyone already accecpted 'silvaco,i3c-master-v1'. >> >> driver part: >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=8911eae9c8a947e5c1cc4fcce40473f1f5e475cd >> dts part: >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b8ec0f3b42a3498d5115d1fb1490082ab525747b > > @Krzysztof: > Patches were accepted after discussion, what you ponit to. So I > think everyone agree on the name 'silvaco,i3c-master-v1'. > I plan send next version to fix auto build error. Any additional > comments about this? I still do not see how did you address Rob's comment and his point is valid. You just did not reply to it. Best regards, Krzysztof
