Re: [PATCH 12/18] serial: sc16is7xx: replace hardcoded divisor value with BIT() macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Hugo Villeneuve <hugo@xxxxxxxxxxx>
Subject: Re: [PATCH 12/18] serial: sc16is7xx: replace hardcoded divisor value with BIT() macro
From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Date: Wed, 20 Dec 2023 17:52:48 +0200
Cc: gregkh@xxxxxxxxxxxxxxxxxxx, jirislaby@xxxxxxxxxx, jringle@xxxxxxxxxxxxx, kubakici@xxxxx, phil@xxxxxxxxxxxxxxx, bo.svangard@xxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
In-reply-to: <20231219171903.3530985-13-hugo@hugovil.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20231219171903.3530985-1-hugo@hugovil.com> <20231219171903.3530985-13-hugo@hugovil.com>

On Tue, Dec 19, 2023 at 12:18:56PM -0500, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> 
> To better show why the limit is what it is, since we have only 16 bits for
> the divisor.

Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko

References:
- [PATCH 00/18] serial: sc16is7xx: fixes, cleanups and improvements
  - From: Hugo Villeneuve
- [PATCH 12/18] serial: sc16is7xx: replace hardcoded divisor value with BIT() macro
  - From: Hugo Villeneuve

Prev by Date: Re: [PATCH 10/18] serial: sc16is7xx: use HZ_PER_MHZ macro to improve readability
Next by Date: Re: [PATCH 11/18] serial: sc16is7xx: add explicit return for some switch default cases
Previous by thread: [PATCH 12/18] serial: sc16is7xx: replace hardcoded divisor value with BIT() macro
Next by thread: Re: [PATCH 00/18] serial: sc16is7xx: fixes, cleanups and improvements
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux PPP] [Linux FS] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Linmodem] [Device Mapper] [Linux Kernel for ARM]