On Tue, Dec 19, 2023 at 12:18:53PM -0500, Hugo Villeneuve wrote: > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > Add macro to hold the maximum number of UART ports per IC/device. ... > - if (count < 0 || count > ARRAY_SIZE(irda_port)) > + if (count < 0 || count > SC16IS7XX_MAX_PORTS) ARRAY_SIZE() is more robust than this. What if you change to support different devices where this won't be as defined? > return; ... > - if (count < 0 || count > ARRAY_SIZE(mctrl_port)) > + if (count < 0 || count > SC16IS7XX_MAX_PORTS) > return 0; Ditto. ... > + WARN_ON(devtype->nr_uart > SC16IS7XX_MAX_PORTS); Not sure about this, perhaps it's fine. Otherwise looks reasonable. -- With Best Regards, Andy Shevchenko
