Hi Michael, kernel test robot noticed the following build errors: [auto build test ERROR on tty/tty-testing] [also build test ERROR on tty/tty-next tty/tty-linus linus/master v6.7-rc5 next-20231215] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Michael-Trimarchi/tty-serial-kgdboc-Fix-8250_-kgd-over-serial/20231217-013726 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing patch link: https://lore.kernel.org/r/20231216173409.1264655-1-michael%40amarulasolutions.com patch subject: [PATCH] tty: serial: kgdboc: Fix 8250_* kgd over serial config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20231217/202312171453.mT4pH4uH-lkp@xxxxxxxxx/config) compiler: sh4-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231217/202312171453.mT4pH4uH-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202312171453.mT4pH4uH-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/tty/serial/serial_core.c: In function 'uart_poll_init': >> drivers/tty/serial/serial_core.c:2636:33: error: lvalue required as left operand of assignment 2636 | if (!port || port->type = PORT_UNKNOWN || !(port->ops->poll_get_char && port->ops->poll_put_char)) { | ^ vim +2636 drivers/tty/serial/serial_core.c 2618 2619 static int uart_poll_init(struct tty_driver *driver, int line, char *options) 2620 { 2621 struct uart_driver *drv = driver->driver_state; 2622 struct uart_state *state = drv->state + line; 2623 enum uart_pm_state pm_state; 2624 struct tty_port *tport; 2625 struct uart_port *port; 2626 int baud = 9600; 2627 int bits = 8; 2628 int parity = 'n'; 2629 int flow = 'n'; 2630 int ret = 0; 2631 2632 tport = &state->port; 2633 mutex_lock(&tport->mutex); 2634 2635 port = uart_port_check(state); > 2636 if (!port || port->type = PORT_UNKNOWN || !(port->ops->poll_get_char && port->ops->poll_put_char)) { 2637 ret = -1; 2638 goto out; 2639 } 2640 2641 pm_state = state->pm_state; 2642 uart_change_pm(state, UART_PM_STATE_ON); 2643 2644 if (port->ops->poll_init) { 2645 /* 2646 * We don't set initialized as we only initialized the hw, 2647 * e.g. state->xmit is still uninitialized. 2648 */ 2649 if (!tty_port_initialized(tport)) 2650 ret = port->ops->poll_init(port); 2651 } 2652 2653 if (!ret && options) { 2654 uart_parse_options(options, &baud, &parity, &bits, &flow); 2655 console_list_lock(); 2656 ret = uart_set_options(port, NULL, baud, parity, bits, flow); 2657 console_list_unlock(); 2658 } 2659 out: 2660 if (ret) 2661 uart_change_pm(state, pm_state); 2662 mutex_unlock(&tport->mutex); 2663 return ret; 2664 } 2665 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
