Re: [PATCH 08/13] arm64: dts: exynos: gs101: enable cmu-peric0 clock controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14/12/2023 16:39, Sam Protsenko wrote:
> On Thu, Dec 14, 2023 at 4:52 AM Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> wrote:
>>
>> Enable the cmu-peric0 clock controller. It feeds USI and I3c.
>>
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>
>> ---
>>  arch/arm64/boot/dts/exynos/google/gs101.dtsi | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
>> index 9747cb3fa03a..d0b0ad70c6ba 100644
>> --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
>> +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
>> @@ -339,6 +339,18 @@ ppi_cluster2: interrupt-partition-2 {
>>                         };
>>                 };
>>
>> +               cmu_peric0: clock-controller@10800000 {
>> +                       compatible = "google,gs101-cmu-peric0";
>> +                       reg = <0x10800000 0x4000>;
>> +                       #clock-cells = <1>;
>> +                       clocks = <&ext_24_5m>,
>> +                                <&cmu_top CLK_DOUT_CMU_PERIC0_BUS>,
>> +                                <&cmu_top CLK_DOUT_CMU_PERIC0_IP>;
>> +                       clock-names = "oscclk",
>> +                                     "dout_cmu_peric0_bus",
> 
> I'd pull this line to the above line. Other than that:
> 

No, it's fine. If clocks span over multiple lines (one clock per line),
the names should follow in general. It's easier to read and match entries.

Best regards,
Krzysztof





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux