On Wed, 13 Dec 2023, Lino Sanfilippo wrote: > On 11.12.23 12:00, Ilpo Järvinen wrote: > > On Sat, 9 Dec 2023, Lino Sanfilippo wrote: > > > Looking into the code, that setting of rs485_supported from imx_no_rs485 > > is actually superfluous as it should be already cleared to zeros on alloc. > > > > Yes. BTW: Another "no_rs485" configuration setting can be found in the ar933x driver. > If we do not want to keep those assignments I can remove the one for the imx > driver with the next version of this patch... I think they can just be dropped as it's normal in Linux code to assume that things are zeroed by default. Those "no"-variants originate from the time when supported_rs485 was not yet embedded but just a pointer to a const struct and I didn't realize I could have removed them when I ended up embedding the struct so it can be altered per port. -- i.
