Hi Jiri,
On Wed, Dec 6, 2023 at 8:37 AM Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx> wrote:
> Switch character types to u8. To conform to characters in the rest of
> the tty layer.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx>
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> --- a/drivers/tty/amiserial.c
> +++ b/drivers/tty/amiserial.c
> @@ -81,7 +81,7 @@ struct serial_state {
> int quot;
> int IER; /* Interrupt Enable Register */
> int MCR; /* Modem control register */
> - int x_char; /* xon/xoff character */
> + u8 x_char; /* xon/xoff character */
> };
>
> static struct tty_driver *serial_driver;
> @@ -178,7 +178,7 @@ static void receive_chars(struct serial_state *info)
> {
> int status;
> int serdatr;
> - unsigned char ch, flag;
> + u8 ch, flag;
> struct async_icount *icount;
> bool overrun = false;
>
I think it would make sense to fold this into "[PATCH 04/27] tty:
make tty_operations::send_xchar accept u8 char".
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
