On 18/11/2023 08:43, Jaewon Kim wrote: > > On 23. 11. 17. 19:48, Krzysztof Kozlowski wrote: >> On 17/11/2023 08:36, Jaewon Kim wrote: >>>>> The reason why I chose variable name 'combine' is that EINT registers was >>>>> separated from gpio control address. However, in exynosautov920 EINT >>>>> registers combined with GPx group. So I chose "combine" word. >>>> What does it mean "the GPx group"? Combined means the same place, the >>>> same register. I could imagine offset is 0x4, what I wrote last time. >>>> >>>> Is the offset 0x4? > > If you are asking about the offset of GPIO control register and EINT > control register, 0x4 is correct. > > There is no empty space between the two register. > > > 0x0 CON > > 0x4 DAT > > 0x8 PUD > > 0xc DRV > > 0x10 CONPDN > > 0x14 PUDPDN > > 0x18 EINT_CON > > 0x1c EINT_FLTCON > > 0x20 or 0x24 EINT_MASK (The size of FLTCON register depending on the > number of gpio) > > 0x24 or 0x28 EINT_PEND > > >>>> >>>> >>>>> Is another reasonable word, I will change it. >>>> Why you cannot store the offset? >>>> >>>>> EINT registers related to the entire group(e.g SVC) were at the end of >>>>> the GPIO block and are now moved to 0xf000. >>>> So not in the same register, not combined? >>>> >>> Okay, >>> >>> Instead of the word combine, I will think of a better word in next version. >> I want to know answer to: >> >> "Why you cannot store the offset?" >> > I did not understand exactly what you said, but if i guess,, > > you want to get rid of the offs because the value of the offs is always > the same? > > #define EXYNOSV920_PIN_BANK_EINTG(pins, reg, id, offs, mask_offs, pend_offs) I meant that it looks possible to store the offset and use it directly, instead of storing bool telling that offset is different. Best regards, Krzysztof
