On 20/11/2023 08:55, Tomas Paukrt wrote: > This patch provides an option to enable the RS485 mode at boot time Please do not use "This commit/patch", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > based on the state of a GPIO pin (DIP switch or configuration jumper). > The GPIO is defined by the device tree property "rs485-mode-gpio". > > Signed-off-by: Tomas Paukrt <tomaspaukrt@xxxxxxxx> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. > --- > Documentation/devicetree/bindings/serial/rs485.yaml | 4 ++++ > drivers/tty/serial/serial_core.c | 12 ++++++++++++ > 2 files changed, 16 insertions(+) Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can be ignored, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. Best regards, Krzysztof
