Re: [PATCH] serial: xilinx_uartps: Fix kernel doc about .remove()'s return code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 11/17/23 11:12, Uwe Kleine-König wrote:
Since the driver was converted to use .remove_new() the return function
doesn't return a value any more. So remove the obsolete documentation
about the return value.

Reported-by: Michal Simek <michal.simek@xxxxxxx>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
---
Hello,

the patch converting to .remove_new is not yet applied, so I didn't
reference its commit id. It's available at

	https://lore.kernel.org/linux-serial/20231110152927.70601-53-u.kleine-koenig@xxxxxxxxxxxxxx

and obviously this patch dropping the comment should get applied after
the conversion to void.

Best regards
Uwe

  drivers/tty/serial/xilinx_uartps.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index 6decf2b13340..920762d7b4a4 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -1663,8 +1663,6 @@ static int cdns_uart_probe(struct platform_device *pdev)
  /**
   * cdns_uart_remove - called when the platform driver is unregistered
   * @pdev: Pointer to the platform device structure
- *
- * Return: 0 on success, negative errno otherwise
   */
  static void cdns_uart_remove(struct platform_device *pdev)
  {

base-commit: eff99d8edbed7918317331ebd1e365d8e955d65e
prerequisite-patch-id: 78ddb8b8246b06d5805c7dc8ad6481c7e4bc22c8


Acked-by: Michal Simek <michal.simek@xxxxxxx>

Thanks,
Michal



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux