On Fri, Nov 10, 2023 at 04:29:47PM +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Thanks!
Acked-by: Gabriel Somlo <gsomlo@xxxxxxxxx>
> ---
> drivers/tty/serial/liteuart.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
> index a25ab1efe38f..3ce369f76349 100644
> --- a/drivers/tty/serial/liteuart.c
> +++ b/drivers/tty/serial/liteuart.c
> @@ -336,15 +336,13 @@ static int liteuart_probe(struct platform_device *pdev)
> return ret;
> }
>
> -static int liteuart_remove(struct platform_device *pdev)
> +static void liteuart_remove(struct platform_device *pdev)
> {
> struct uart_port *port = platform_get_drvdata(pdev);
> unsigned int line = port->line;
>
> uart_remove_one_port(&liteuart_driver, port);
> xa_erase(&liteuart_array, line);
> -
> - return 0;
> }
>
> static const struct of_device_id liteuart_of_match[] = {
> @@ -355,7 +353,7 @@ MODULE_DEVICE_TABLE(of, liteuart_of_match);
>
> static struct platform_driver liteuart_platform_driver = {
> .probe = liteuart_probe,
> - .remove = liteuart_remove,
> + .remove_new = liteuart_remove,
> .driver = {
> .name = KBUILD_MODNAME,
> .of_match_table = liteuart_of_match,
> --
> 2.42.0
>
