On 2023-10-16 14:32, Jiri Slaby wrote:
On 16. 10. 23, 9:13, Florian Eckert wrote:
Tabs were used in the function description, to make this look more
uniform, the tabs were replaced by spaces where necessary.
Signed-off-by: Florian Eckert <fe@xxxxxxxxxx>
Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>
Thanks for the review and adding your 'Reviewed-by:'.
Will add this to the v4 if I get feedback form the led
subsystem maintainers, if my change to ledtrig-tty are
correct. So this could get into for-led-next [1]
maintained by Lee Jones <lee@xxxxxxxxxx>
LGTM (spihnx prefers spaces), except:
@@ -3470,7 +3470,7 @@ int tty_register_driver(struct tty_driver
*driver)
EXPORT_SYMBOL(tty_register_driver);
/**
- * tty_unregister_driver -- unregister a tty driver
+ * tty_unregister_driver - unregister a tty driver
you should have noted you changed ndashes to dashes too. (As only the
latter is supported by sphinx.)
That was intentional.
However, I did not mention it in the commit message.
My mistake. Sorry.
Will add this to the information to an v4.
--
Florian
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git/log/?h=for-leds-next
