Re: [PATCH v3 3/4] trigger: ledtrig-tty: move variable definition to the top

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Florian Eckert wrote on 2023-10-16 09:13:
Has complained about the following construct:

Who is "Has" or who/what has complained?

drivers/leds/trigger/ledtrig-tty.c:362:3: error: a label can only be
part of a statement and a declaration is not a statement

Hence move the variable definition to the beginning of the function.

Reported-by: kernel test robot <lkp@xxxxxxxxx>
Closes:
https://lore.kernel.org/oe-kbuild-all/202309270440.IJB24Xap-lkp@xxxxxxxxx/
Signed-off-by: Florian Eckert <fe@xxxxxxxxxx>
---
@@ -124,8 +125,6 @@ static void ledtrig_tty_work(struct work_struct *work)

 	if (icount.rx != trigger_data->rx ||
 	    icount.tx != trigger_data->tx) {
-		unsigned long interval = LEDTRIG_TTY_INTERVAL;
-

Is this kernel test robot broken?
I see no label definition here.
And this variable declaration is at the start of a new block which does not
even require C99 support.

 		led_blink_set_oneshot(trigger_data->led_cdev, &interval,
 				      &interval, 0);

Maarten




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux